lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
21 stars 12 forks source link

clean up utils and shared code #48

Closed lowlydba closed 2 years ago

lowlydba commented 2 years ago

Description

Clean up utils and shared code.

How Has This Been Tested?

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #48 (c4ea435) into main (613dbde) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   94.97%   94.93%   -0.04%     
==========================================
  Files          33       33              
  Lines        1014      988      -26     
==========================================
- Hits          963      938      -25     
+ Misses         51       50       -1     
Impacted Files Coverage Δ
plugins/module_utils/_SqlServerUtils.psm1 95.65% <100.00%> (+2.31%) :arrow_up:
plugins/modules/agent_job.ps1 95.83% <100.00%> (-0.12%) :arrow_down:
plugins/modules/agent_job_category.ps1 94.44% <100.00%> (-0.30%) :arrow_down:
plugins/modules/agent_job_schedule.ps1 96.70% <100.00%> (-0.08%) :arrow_down:
plugins/modules/agent_job_step.ps1 97.75% <100.00%> (-0.05%) :arrow_down:
plugins/modules/database.ps1 84.89% <100.00%> (-0.22%) :arrow_down:
plugins/modules/login.ps1 96.25% <100.00%> (-0.10%) :arrow_down:
plugins/modules/maintenance_solution.ps1 94.11% <100.00%> (-0.17%) :arrow_down:
plugins/modules/memory.ps1 95.83% <100.00%> (-0.33%) :arrow_down:
plugins/modules/nonquery.ps1 96.29% <100.00%> (-0.26%) :arrow_down:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 613dbde...c4ea435. Read the comment docs.

lowlydba commented 2 years ago

Windows 2022 basically times out with

An error occurred while provisioning resources (Error Type: Disconnect).

Presumably this is an error on the infra side, so moving back to 2019 for the time being.