lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
21 stars 12 forks source link

Add sa module #55

Closed lowlydba closed 2 years ago

lowlydba commented 2 years ago

Description

Add a module for hardening the sa login.

Also a bug fix for the login module.

Do not merge until https://github.com/dataplat/dbatools/pull/8289 is landed & the LoginName/Name defaults in the integration tests can be cleaned up.

How Has This Been Tested?

Types of changes

Checklist:

github-actions[bot] commented 2 years ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main.

codecov-commenter commented 2 years ago

Codecov Report

Merging #55 (792debd) into main (da4a65c) will increase coverage by 0.22%. The diff coverage is 96.34%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   95.00%   95.22%   +0.22%     
==========================================
  Files          35       37       +2     
  Lines        1021     1090      +69     
==========================================
+ Hits          970     1038      +68     
- Misses         51       52       +1     
Impacted Files Coverage Δ
plugins/modules/login.ps1 96.59% <90.47%> (+0.34%) :arrow_up:
plugins/modules/sa.ps1 98.27% <98.27%> (ø)
plugins/modules/sa.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da4a65c...792debd. Read the comment docs.