Py3 qt5

[Valdas2000]

Changes: 1 - Midline used everywhere for calculations 2 - Allow even and odd bits for dovetail joins 3 - min_finger_width respected across all functionality 4 - gap calculation optimized 5 - Midline depended on bit height ( so usually there are 2 optimal height values for a dovetail bit) 6 - qt_test got back (QT5 migration)

Fixes: 1 - Screenshot got back (QT5 fix) 2 - Mouse events for zooming got back (QT5 fix) 3 - Save configuration fixed (typo in initial version) 4 - Application Works fine on multi-screen (up to 4 screen configuration verified) TODO: 1 - optimize router cuts ( cuts more that half bit diameter are not welcomed), edge cuts must be delicate 2 - show optimal bit height for dovetails (bit.height_0) 3 - update signs for templates stripes showing bit info and optimal height 4 - allow reverse in variable spacing (probably it's better to put a slider for fine tune d value) 5 - Disallow fractional diameters for straight bits in metric Limitations: 1 - Metric users must care. Fractional values allowed only for dovetails. Fractional in dovetails causes error 2 - works well on 1mm precision (other values are not well tested) 3 - Alignment line fixed to 0 (it will be fine to adopt it to edge point)

[lowrie]

Looks great, Valdas. I'll merge this, but we also need metric tests in qt_test.py.

[Valdas2000]

I am working on them. Scheduled fot the next commit

10 февр. 2018 г. 5:28 PM пользователь "Robert B. Lowrie" < notifications@github.com> написал:

Merged #4 https://github.com/lowrie/pyRouterJig/pull/4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lowrie/pyRouterJig/pull/4#event-1468016556, or mute the thread https://github.com/notifications/unsubscribe-auth/AhlUv9f3tRAXNu_OkLUEP7cZuQA1LaAaks5tTadwgaJpZM4R-WiS .

[lowrie]

I also run pylint (which uses pylintrc) to try to find formatting issues and unused variables. I'll push some changes soon with that cleanup.

[Valdas2000]

Hello I ran pylint over the code. Got number of warnings and fix some of them. So next request will be mostly about code formatting and refactoring. I think we are going to stay on Python3 so I'll remove 2.7 stuff completelly. OK ?

Regards Valentin.

Regards Valentin.

On Sat, Feb 10, 2018 at 9:56 PM, Robert B. Lowrie notifications@github.com wrote:

I also run pylint (which uses pylintrc) to try to find formatting issues and unused variables. I'll push some changes soon with that cleanup.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lowrie/pyRouterJig/pull/4#issuecomment-364680501, or mute the thread https://github.com/notifications/unsubscribe-auth/AhlUv6krfaAs2se500XSQXTTzZQlrYoVks5tTeZRgaJpZM4R-WiS .

-- Regards Valentin