search

lowrie / pyRouterJig

pyRouterJig is a woodworking layout tool for creating box and dovetail joints
GNU General Public License v3.0
19 stars 12 forks source link

Py3 qt5 #6

Open Valdas2000 opened 6 years ago

Valdas2000 commented 6 years ago

Hello. Seems my changes looks good with your updates. There are following fixes introduced: 1 - Fixed issue in open files saved from a different language (custom pattern translation may be lost) The PNG file saved in other than English localization opens with no errors in English version (cuts fine but fills change to defaults) The PNG saved in English localization opens fine in any localization /I will continue efforts to get complete localization compatibility/

2 - Change labels in Incra Template Seems the template became more informative now.

3 - Fixed print issue for colored Templates. The PNG image converted into sRGB profile (the profile saved into the file). So it should be printed well and displayed correct colors on various monitors

4 - Code refactored. Decimal aliased to D. It just to simplify the code,

5 - future removed. Seems we need no future anymore because on python3. The point is that print is already in python3 Python3 offers float as result of integer division. This code was refactored lrange migrated to range

lowrie commented 6 years ago

@Valdas2000 I'm having difficulty with my python installation and

from PIL import ImageCms

I get

Traceback (most recent call last):
  File "/anaconda3/lib/python3.6/site-packages/PIL/ImageCms.py", line 23, in <module>
    from PIL import _imagingcms
ImportError: cannot import name '_imagingcms'

This appears to be a common issue with anaconda. I'll try to figure out a way around it, but it may delay merging this PR.

Valdas2000 commented 6 years ago

Hello BTW. I used Pillow 5.0.0 which is a PIL fork. May be that is the cause pip install Pillow

There was an issue https://github.com/ContinuumIO/anaconda-issues/issues/371 But I did not dig into the fix. (Mac is too complex for me)

lowrie commented 6 years ago

Yes, I saw the 371 issue. For some reason, anaconda is not supporting littlecms in the pillow build. This issue has been around for many years.

Valdas2000 commented 6 years ago

Got one more question. Let's say we are going to print a saved PNG the point is we have "fixed" size So it is not possible to get properly size of print

Do you have any Ideas

(For now I add dimensions to the lower left corner).

lowrie commented 6 years ago

This looks good, but I want to change a few minor things before merging. See my push to this in your repo.

Valdas2000 commented 6 years ago

Ok. I will wait for your commits.

Valdas2000 commented 6 years ago

Seems it is also need to keep the path not only on save but on open as well. May be it will be also good to have Save and Save as... It's not a big deal but I am not sure if it is make sense for our tasks.