search

lox / pheasant

A lightweight data mapper designed to take advantage of PHP 5.3+
http://getpheasant.com
MIT License
101 stars 21 forks source link

Make sure variable can be set to NULL if empty string before #106

Closed bjornpost closed 10 years ago

bjornpost commented 10 years ago

I've changed the comparison operator to Identical (===) instead of Equal (==). Also included a testcase.

lox commented 10 years ago

I'm concerned that might have unintended consequences. Let me try it out on some of my codebases.

bjornpost commented 10 years ago

iirc the extra if statement was added to make sure the changes method only returned fields that've really changed.

Good to check for unintended consequences though.

Op 15 apr. 2014 om 02:39 heeft Lachlan Donald notifications@github.com het volgende geschreven:

I'm concerned that might have unintended consequences.

— Reply to this email directly or view it on GitHub.

lox commented 10 years ago

I've merged this, think it will merit a minor version bump.