search

lox / pheasant

A lightweight data mapper designed to take advantage of PHP 5.3+
http://getpheasant.com
MIT License
101 stars 21 forks source link

Allow identical joins only once #127

Open Jud opened 9 years ago

Jud commented 9 years ago

We have multiple loosely coupled methods that pass around unexecuted Collection objects and join/filter as they need. It's possible to get into a situation where multiple methods need to join a table, but can't be certain whether it has or has not been joined.

This only allows distinct join statements -- which makes it easier to have more loosely coupled methods that pass around Collections.

bjornpost commented 9 years ago

LGTM :+1:

bjornpost commented 9 years ago

Can you rebase this?

bjornpost commented 8 years ago

@Jud can you rebase this to master?