search

lox / pheasant

A lightweight data mapper designed to take advantage of PHP 5.3+
http://getpheasant.com
MIT License
101 stars 21 forks source link

Support nested transactions using SAVEPOINT #142

Open Jud opened 9 years ago

Jud commented 9 years ago

The base branch for #111 was deleted, so I'm opening a new PR with a new base branch.

(Fixes #56)

bjornpost commented 9 years ago

That's quite a PR, nice work! I'll have a look at this once we have 1.3.2 released. Would you mind writing some documentation for this as well? IIRC transactions are currently not explained at all in the docs.

bjornpost commented 9 years ago

Code LGTM. An example of how to use in the docs would be great. While you're at it, maybe we can also add an extra example of how Events work?

bjornpost commented 8 years ago

@Jud ping for docs :-)

Jud commented 6 years ago

@bjornpost re: the docs, they are relatively unchanged. IMO this just makes the existing transaction code work like a casual observer would expect them to. I'll open another issue for cleaning up event docs.

Edit: btw, we've been running this code in production since ~2015. May be some corner cases we're not running into, but generally works as expected.