lox / regreph

A tool for detecting performance regressions in PHP codebases
50 stars 2 forks source link

Add symfony commands and extract logic #17

Closed hkdobrev closed 10 years ago

hkdobrev commented 10 years ago

This is still work in progress, but I'm opening the PR early to gather more input.

I've started this to tackle only #9 at first. But I quickly saw this would not work except I also handle #10.

I think I've explained my changes well enough in the commits.

lox commented 10 years ago

Thoughts on making the classes PSR-2 compliant?

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md https://github.com/fabpot/PHP-CS-Fixer

Makes it easier for others to contribute. Otherwise, looking good!

hkdobrev commented 10 years ago

@lox

Thoughts on making the classes PSR-2 compliant?

I'd like that as well. But I've wanted for the time being to port the existing code and make it PSR-2 compliant (even with Symfony2 coding standards and naming conventions) later.

What do you prefer?

or

Added an issue for further discussion: #18

lox commented 10 years ago

These look good, let's just get them into master and work to get everything a bit more object-oriented.

hkdobrev commented 10 years ago

@lox This was not quite ready yet, unfortunately. The regreph command did not work well, because I've removed the directory setting from the benchmarking as I thought it was not needed. But I was wrong. Do you have an idea how to fix it nicely?

I was thinking to abstract the directory thing. So both the benchmarking and the regression testing will receive a working directory, but they will not handle the actual directory creating, git revisions etc.