search

loxilb-io / kube-loxilb

Implementation of kubernetes service load-balancer spec for loxilb
Apache License 2.0
92 stars 25 forks source link

Code refactoring to check annotations. #193

Open backguynn opened 1 month ago

backguynn commented 1 month ago

K8s 서비스 생성시, kube-loxilb에서 서비스의 annotation을 체크하고 변수에 값을 할당하는 부분이 있습니다. 다음과 같은 부분입니다.

https://github.com/loxilb-io/kube-loxilb/blob/6319932eadf17e5cdc9bd30ba956bf94bf7aa62a/pkg/agent/manager/loadbalancer/loadbalancer.go#L374-L406

annotation 체크하는 부분을 따로 함수로 빼고, 변수들은 따로 struct로 묶어서 해당 함수에서 struct 값을 업데이트한 다음, 다른 곳에서도 변수 대신 struct를 사용하도록 하면 코드가 좀 더 깔끔해질 것 같습니다.

===============

When creating a K8s service, there is a part in kube-loxilb that checks the annotation of the service and assigns values ​​to variables.

Extract the annotation checking part into a separate function, group the variables into a separate struct, and update the struct value in the function. I think the code would be cleaner if we used structs instead of variables in other places as well.

YelynnOh commented 1 month ago

I'm interested in this issue! Would be glad to work on this.