loyno-mathcs / workforwardnola

2016 NOLA Fellowship project | A mobile-first website that acts as a digital one-pager for the workforce system in New Orleans, reducing drop-off by setting proper expectations and preparing job seekers for their first visit.
http://careerpathnola.com
MIT License
2 stars 3 forks source link

Needed to update Ruby to 2.5.1 #62

Closed tmloupe closed 5 years ago

tmloupe commented 6 years ago

AWS Elastic Beanstalk complained about ruby versioning. 2.2 is EOL and 2.2.5 is not supported within EB, so we made the change to 2.3.7. We also needed to update Sass to 3.6 because that was throwing a bunch of unfun warnings.

Needs to be tested before we push this into master to make sure the new Ruby update doesn't break. More to come.

nihonjinrxs commented 6 years ago

While we're updating, might be worthwhile to try and get to 2.5.3 (latest Ruby version). Not an imperative, but better to deliver on latest if possible.

tmloupe commented 6 years ago

Update: We went ahead and updated to 2.5.1 and ensured it worked - latest Ruby version is ready to go for a few more years!

nihonjinrxs commented 5 years ago

@tmloupe Any reason I shouldn't merge this now?

nihonjinrxs commented 5 years ago

Did some more cleanup of code. I think this looks good to merge. Please test/validate, and if OK, I'll merge this to master branch.

tmloupe commented 5 years ago

I went through and did a test of the app and it seems like nothing has gone haywire. Looks safe to merge.

nihonjinrxs commented 5 years ago

OK, merging.