loyolauniversitychicago / loyola-template-4.0

A comprehensive, intuitive, and responsive template designed to facilitate web page and website design using the Loyola University Chicago brand design schema
1 stars 0 forks source link

Unusual "a href" links and Button behavior #10

Open williambeeler opened 2 years ago

williambeeler commented 2 years ago

I've noticed several places where there are oddities with A Href or Buttons. Here's one:

Screen Shot 2022-08-04 at 10 17 37 AM

In this case, there is javascript in the href. If you need to use a placeholder, the following will suffice:

<a href="#">Some Link</a>

Another place you have 3 hashtags:

Screen Shot 2022-08-04 at 10 24 11 AM

This isn't necessarily wrong, but for consistency sake, I would just stay with one hashtag.

Also, you have button onclick events like these:

Screen Shot 2022-08-04 at 10 29 07 AM

That is a very odd formation. I would recommend the above re-worked like the following:

<a href="#">
   <button class="button-maroon">CTA here</button>
</a>

OR, alternatively:

<a href="#" class="button-maroon">CTA here</a>