search

lpantano / seqcluster

small RNA analysis from NGS data
http://seqcluster.readthedocs.io
MIT License
35 stars 17 forks source link

proressbar new api; lazy output decoding #40

Closed kkarolis closed 5 years ago

kkarolis commented 5 years ago

Hey,

Thanks a lot for open sourcing this software. I was trying to package it for the upcoming debian release (python3 only) but it seems the development version (devel branch) doesn't package very well because the tests are not passing. I tried to wing it and make the tests pass by doing some simple changes provided in this PR. It involves new ProgressBar api and decoding the subprocess output.

Since encoding from subprocess is basically unknown it seems. chardet could possibly be used to detect the encoding of stdout for a better and more compatible solution.

Regards

kkarolis commented 5 years ago

The package repo is on med-team/python-seqcluster

lpantano commented 5 years ago

Thanks so much. I will do a release soon.