search

lpatmo / cb-links

Archive of resources. Open collaborative project.
http://links.codebuddies.org/
MIT License
5 stars 1 forks source link

1 "Recommendations" should say 1 "Recommendation" #12

Open lpatmo opened 9 years ago

lpatmo commented 9 years ago

Not sure whether this can be solved inside in the custom en.i18n.json file or elsewhere.

lpatmo commented 9 years ago

Thanks @anbuselvan for pointing out that this is a larger bug with Telescope that might need a PR.

anbuselvan commented 9 years ago

@lpatmo I spent couple hours to go through the telescope code and found out that, telescope is using version 1.4.1 from tap:i18n package, but there is an improvement already pushed by @SachaG which will help to handle the duplicate items efficiently. If @SachaG is comfortable to get the latest with his fix then my fix will make more sense, but it's a p1 bug in Telescope right now. So, we have to wait until his recent change on tap:i18n package got integrated with telescope, then I'll add my PR to fix this item.

SachaG commented 9 years ago

Sorry, I'm not super clear on what I need to do?

anbuselvan commented 9 years ago

@SachaG in the telescope-lib package the tap:i18n package has been included like this.

'tap:i18n@1.4.1',

but I saw you already pushed an enhancement which is accepted by tap:i18n package project.

As you can notice from telescope-core/i18n/en.i18n.json there are many duplicates.

"comments": "Comments",
"comments": "comments",

+

"comments_": "Comments",

So, your commit will fix this by having translation items by category, which will make our life easier to organize. For that we need to include the i18n package without version number to get your fix as well.

'tap:i18n',

Also, it'll help me to fix this issue on cb-links as well like 1 Recommendation, 2 Recommendations etc., but we just don't want to fix it in cb-links alone. So, I'm working on a PR for telescope, it's a huge change like reorganizing the translation content in all languages but worth to do it in the right way.

anbuselvan commented 9 years ago

@SachaG another question, is it okay I can remove the version number as part of my PR?

SachaG commented 9 years ago

I'm a bit confused, because my PR only changed the documentation, and I also don't see what it has to do with the singular/plural thing.

As for specifying a version number, I had to do it because I was getting an error otherwise. So I guess for now we'll have to update version numbers manually, sorry…

anbuselvan commented 9 years ago

@SachaG I'm on it. This will be my first PR for Telescope. I'll get back to you once I fixed and tested this plural issue. I recently worked on a project that uses the i18n package efficiently, and I'm trying to bring all those good stuff to Telescope.

anbuselvan commented 9 years ago

by the way, I realized later that you had updated the documentation, which is nothing to do with version number. So, I've everything I need.