Open eduardomozart opened 1 year ago
As cited on #296, the SVG embedding function is still broken.
When using the following fork from PlantUML Parser: https://github.com/eduardomozart/dokuwiki_plantumlparser/tree/56a82f450a611338d8771e888a1d9774306e7219
I intentionally commented the line $renderer->_addStringAsSVGImage because embedding a SVG image on an ODT file using it simply fails.
$renderer->_addStringAsSVGImage
There's other plugins that relies on this method to embed SVG images on ODT files, as dokuwiki-plugin-switchpanel, as can be seen in https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel/blob/561d049aef21afb3d54406d1b62373e8275ce766/syntax.php#L467
I attempted to create a fix at https://github.com/lpaulsen93/dokuwiki-plugin-odt/pull/293 but the function is now being called as it should but it didn't seem to fix the issue.
As cited on #296, the SVG embedding function is still broken.
When using the following fork from PlantUML Parser: https://github.com/eduardomozart/dokuwiki_plantumlparser/tree/56a82f450a611338d8771e888a1d9774306e7219
I intentionally commented the line
$renderer->_addStringAsSVGImagebecause embedding a SVG image on an ODT file using it simply fails.There's other plugins that relies on this method to embed SVG images on ODT files, as dokuwiki-plugin-switchpanel, as can be seen in https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel/blob/561d049aef21afb3d54406d1b62373e8275ce766/syntax.php#L467
I attempted to create a fix at https://github.com/lpaulsen93/dokuwiki-plugin-odt/pull/293 but the function is now being called as it should but it didn't seem to fix the issue.