search

lpaulsen93 / dokuwiki-plugin-odt

Exports a page to the Open Document format used by OpenOffice.org and other word processors
http://www.dokuwiki.org/plugin:odt
13 stars 26 forks source link

Fix PHP 8 warning when exporting books to ODT #313

Closed eduardomozart closed 9 months ago

Klap-in commented 9 months ago

Please could you use more descriptive commit messages? I guess you are modifying files via the web interface of GitHub. Please consider a local setup with git, such that you can submit changes directly from your development environment to GitHub, without use of the web interface.

For more info see also https://www.dokuwiki.org/devel:git and https://www.dokuwiki.org/devel:github

No idea if you use an IDE, if not you might consider Intellij IDEA or Phpstorm, see for more info https://www.dokuwiki.org/devel:intellij_idea

eduardomozart commented 9 months ago

I use Visual Studio Code and GitHub Desktop, I didn't write description because I think that code is self-explanatory (just a small change from explode to sexplode), no big deal, but I can provide more info on newer PR's, no problem.

Klap-in commented 9 months ago

Ok, good tools already!

In the history you see the commit messages, but not the title of the pull request. The pull request title explained here why you made the change, but if you would check later the history of this file you will not see that anymore. Therefore my request to have that description already in the commit message. In title of the pull request it is for me fine if you use something quick and simple.