search

lpc-rs / lpc-pac

Peripheral Access Crates for LPC microcontrollers
9 stars 9 forks source link

bump tool version #75

Closed allexoll closed 2 years ago

allexoll commented 2 years ago

there is a more recent svd2rust but it seems that svd2rust PR #649 has broken something, so that will be bumped later.

Cluster SECCHANNEL[%s] has size 24928 bits that is more then array increment 256 bits
github-actions[bot] commented 2 years ago

Memory map comparison

lucab commented 1 year ago

I think this forgot to update the tools in generate.sh: https://github.com/lpc-rs/lpc-pac/blob/29d8428715daf72492e18e56187827a8c49be891/generate.sh#L67-L69

allexoll commented 1 year ago

that was intentional, there are 2 types of pacs in this repository:

The new pacs don't use the generate.sh, but rather the same process as is done over @ stm32-rs.

as I did not want to create breaking change when introducing this updated workflow, the generate.sh was not updated for that, but if you want to try to update the tools for the legacy pacs, I'd happily merge the PR!

The idea at some point is to update the legacy pacs to the new workflow, but they have not been maintained for a long time, so it would break the HALs to do that as well.

lucab commented 1 year ago

Ah, makes sense. Unfortunately svd2rust-0.24.0 has been yanked so it is not directly installable anymore.

allexoll commented 1 year ago

then you can try with a more recent one, I'll see if I can do a PR later today

lucab commented 1 year ago

Thanks, I'll try with 0.24.1. But I was really trying to have newer LPC13xx PACs, I guess I'll try using the new style instead.

Unrelated to this, I do currently own lpc81x-pac on crates.io and I'll be happy so coordinate publishing a new version from lpc-pac sources.

allexoll commented 1 year ago

ah nice! well regarding the lpc13xx, I think adding it as a new style PAC would be best, normally, all the steps are in the readme, and I can troubleshoot with you any issues you might have,

and for the lpc81x-pac, the worry is that depending on how long ago the hal was published, there might be a lot of breaking changes introduces, as well as any fix to the original SVD. If you want to move the HAL under lpc-rs, that could be done as well, and I think we could add you as a team member?

lucab commented 1 year ago

For lpc81x I did keep the original vendor SVD file (v0.3) as well as my manually-patched version: https://github.com/lucab/lpc81x-pac/tree/master/svd. However I don't own the lpc81x-hal crate, for that one you'll have to ask @apparentlymart.