lpdumas / gw2cbackend

Backend for gw2cartographers.com
2 stars 2 forks source link

changing «name» attr for «title» in default value #9

Closed lpdumas closed 12 years ago

lpdumas commented 12 years ago

The script that parse default value is the same for non-default value.

"bone_chip" : {
            icon : "crafting_material/bone_chip.jpg",
            data_translation : {
                fr : {
                    name : "Bone Chip", //<-----here
                    link_wiki : "",
                    link_gw2data : "",
                    desc : ""
                },
                en : {
                    name : "Bone Chip", //<-----here
                    link_wiki : "",
                    link_gw2data : "",
                    desc : ""
                }
            },
            markers : [
            ]
        }

// explore marker exemple
[...],
{
  id : 444, lat : 8.92848706267, lng : -0.3076171875, area : 11, 
  data_translation : {
    en : {
      title : "", 
      desc : "",
      link_wiki : ""
    },
    fr : {
      title : "",
      desc : "",
      link_wiki : ""
    }
  }
}, [...]
lpdumas commented 12 years ago

same for all default value ;) (pets, books seller, etc)

jsilvestre commented 12 years ago

Both are needed actually, title and name. Name is for the menu and title for the marker.

This should be working for pets and trainers, but I forgot to change the pets' fieldset.

The most up-to-date version is here http://gw2c.jsilvestre.fr/config.js. You can update it with the /admin/generate route.

lpdumas commented 12 years ago

You're right XD. I'll check what i can't do client side ;)

jsilvestre commented 12 years ago

Actually there is nothing to do client-side. Everything is pretty nice here (even if the title/name is kind of weird). No need to add anything that would provoke more bugs than improvements.

lpdumas commented 12 years ago

I meat for infowindow. Right now, it doesn't show anything ;) (on gw2c)

jsilvestre commented 12 years ago

Ok I let you fix that then ! :)