search

lpenz / docker-debian-releases

Creates docker images of historic Debian-based distribution releases
https://www.lpenz.org/docker-debian-releases/
MIT License
23 stars 6 forks source link

option "-i" is ignored #1

Closed SubOptimal closed 5 years ago

SubOptimal commented 5 years ago

The image name passed as -i some-image-name is always ignored.

In the script is will be overridden at this stage

name=debian-${dist}-${arch}
image=${image-"$name"}
lpenz commented 5 years ago

Have you tested this out? It's actually working for me, because ${image-"$name"} returns the value of $image if the variable is set.

Reference: https://www.tldp.org/LDP/abs/html/parameter-substitution.html#DEFPARAM1

SubOptimal commented 5 years ago

Sorry disturbing you. It's working as expected.

The issue was on my system. When I modified the script to make it runnable without sudo I messed up the environment somehow.

lpenz commented 5 years ago

Phew! :) Thanks for looking after this though, and for using the script!