lpenz / ghaction-cmake

cmake swiss army knife github docker action
MIT License
22 stars 13 forks source link

Allow sanitizer recovery #18

Open jayvdb opened 2 years ago

jayvdb commented 2 years ago

It is often useful to allow sanitizer recovery in order to see all errors instead of only the first. This can be done with varying success using -DCMAKE_{}_FLAGS=-fsanitize-recover=all

Using input cmakeflags to add -DCMAKE_{}_FLAGS=-fsanitize-recover=all does not appear to work with these presets, as sanitizer presets already append -DCMAKE_{}_FLAGS.

The recipe should detect input cmakeflags setting -DCMAKE_{}_FLAGS and append its additions into the existing one rather than add another one.

But even with that fixed, IMO it would be good for the recipe here to allow adding -fsanitize-recover=all easily, or at least document how to do it.