bp0 commented 7 years ago

As mentioned in #33 (a conversation that went way off-topic), the code uses a mix of spaces and tabs for indentation. I prefer spaces, so I've been using spaces in all new code, and converting old code that I edit.

tabspace

Status

Checked means cleaned. Uses all spaces (or tabs, but not a mix) for indentation; has no whitespace on empty lines. (as of 8e4746423c20b525671998b1bc94b3b6d8ec78d6)

[ ] hardinfo/binreloc.c
[ ] hardinfo/expr.c
[ ] hardinfo/hardinfo.c
[ ] hardinfo/socket.c
[ ] hardinfo/util.c
[ ] hardinfo/vendor.c
[x] includes/alpha/processor-platform.h
[x] includes/arm/processor-platform.h
[x] includes/benchmark.h
[x] includes/binreloc.h
[ ] includes/blowfish.h
[x] includes/callbacks.h
[ ] includes/computer.h
[x] includes/cpu_util.h
[x] includes/devices.h
[x] includes/dt_util.h
[ ] includes/egg-markdown.h
[x] includes/expr.h
[x] includes/fftbench.h
[x] includes/gettext.h
[x] includes/guibench.h
[x] includes/hardinfo.h
[ ] includes/help-viewer.h
[x] includes/ia64/processor-platform.h
[x] includes/iconcache.h
[x] includes/loadgraph.h
[x] includes/m68k/processor-platform.h
[ ] includes/markdown-text-view.h
[x] includes/md5.h
[x] includes/menu.h
[x] includes/mips/processor-platform.h
[x] includes/network.h
[x] includes/nqueens.h
[x] includes/parisc/processor-platform.h
[x] includes/ppc/processor-platform.h
[x] includes/remote.h
[ ] includes/report.h
[x] includes/riscv/processor-platform.h
[x] includes/s390/processor-platform.h
[x] includes/sh/processor-platform.h
[x] includes/sha1.h
[ ] includes/shell.h
[x] includes/socket.h
[x] includes/sparc/processor-platform.h
[ ] includes/ssh-conn.h
[x] includes/stock.h
[ ] includes/syncmanager.h
[x] includes/test-utils.h
[x] includes/uidefs.h
[x] includes/vendor.h
[x] includes/x86/processor-platform.h
[x] includes/xmlrpc-client.h
[x] includes/xmlrpc-server.h
[ ] modules/benchmark.c
[ ] modules/benchmark/blowfish.c
[ ] modules/benchmark/cryptohash.c
[ ] modules/benchmark/drawing.c
[ ] modules/benchmark/fbench.c
[ ] modules/benchmark/fft.c
[ ] modules/benchmark/fftbench.c
[ ] modules/benchmark/fib.c
[ ] modules/benchmark/guibench.c
[ ] modules/benchmark/md5.c
[ ] modules/benchmark/nqueens.c
[ ] modules/benchmark/raytrace.c
[ ] modules/benchmark/sha1.c
[ ] modules/benchmark/zlib.c
[x] modules/computer.c
[x] modules/computer/alsa.c
[x] modules/computer/boots.c
[ ] modules/computer/display.c
[x] modules/computer/environment.c
[x] modules/computer/filesystem.c
[ ] modules/computer/groups.c
[ ] modules/computer/languages.c
[x] modules/computer/loadavg.c
[x] modules/computer/memory.c
[ ] modules/computer/modules.c
[ ] modules/computer/os.c
[x] modules/computer/uptime.c
[x] modules/computer/users.c
[ ] modules/devices.c
[x] modules/devices/alpha/processor.c
[x] modules/devices/arm/arm_data.c
[x] modules/devices/arm/arm_data.h
[x] modules/devices/arm/processor.c
[ ] modules/devices/battery.c
[x] modules/devices/cpu_util.c
[x] modules/devices/devicetree.c
[x] modules/devices/devicetree/dt_util.c
[x] modules/devices/devicetree/pmac_data.c
[x] modules/devices/devicetree/rpi_data.c
[x] modules/devices/devmemory.c
[ ] modules/devices/dmi.c
[x] modules/devices/ia64/processor.c
[ ] modules/devices/inputdevices.c
[x] modules/devices/m68k/processor.c
[x] modules/devices/mips/processor.c
[x] modules/devices/parisc/processor.c
[ ] modules/devices/pci.c
[x] modules/devices/ppc/processor.c
[ ] modules/devices/printers.c
[ ] modules/devices/resources.c
[x] modules/devices/riscv/processor.c
[x] modules/devices/riscv/riscv_data.c
[x] modules/devices/riscv/riscv_data.h
[x] modules/devices/s390/processor.c
[x] modules/devices/sensors.c
[x] modules/devices/sh/processor.c
[x] modules/devices/sparc/processor.c
[x] modules/devices/spd-decode.c
[ ] modules/devices/storage.c
[ ] modules/devices/usb.c
[ ] modules/devices/x86/processor.c
[x] modules/devices/x86/x86_data.c
[x] modules/devices/x86/x86_data.h
[ ] modules/network.c
[x] modules/network/net.c
[ ] modules/network/nfs.c
[ ] modules/network/samba.c
[ ] shell/callbacks.c
[ ] shell/iconcache.c
[x] shell/loadgraph-uber.c
[x] shell/loadgraph.c
[ ] shell/menu.c
[ ] shell/report.c
[ ] shell/shell.c
[ ] shell/stock.c
[ ] shell/syncmanager.c

mckaygerhard commented 7 years ago

i have a pull #94 that said 4 spaces for identation, will be or 8 or other? will be a mixure of or only SPACES?

bp0 commented 7 years ago

I use 4, but whatever looks nice where it is used. If the pyramid is getting big, perhaps only use 2 for that block. Doesn't need to be a hard rule.

lpereira commented 7 years ago

Might be better to just use clang-format throghout.

mckaygerhard commented 7 years ago

so well? clang-format have several style options, might be difficult to determine prefered.. https://clang.llvm.org/docs/ClangFormatStyleOptions.html

due that you can put after merged or here what might be in the CONTRIBUTING.md file of pull #95

bp0 commented 7 years ago

clang-format is kindof nice, but there are a couple problems with hardinfo. For example: https://github.com/lpereira/hardinfo/blob/master/modules/devices/x86/processor.c#L386 clang-format squishes it all into one giant block of parameters to the printf.

I think clang-format could be useful, but I don't think running it on the whole tree is a good idea.

Here is a candidate .clang-format

BasedOnStyle:  LLVM
IndentWidth:     4
ColumnLimit:     100
TabWidth:        8
UseTab:          Never
AlignEscapedNewlines: Left
AlwaysBreakAfterReturnType: None
AllowShortBlocksOnASingleLine: true
AllowShortCaseLabelsOnASingleLine: true
AllowShortFunctionsOnASingleLine: false
AllowShortIfStatementsOnASingleLine: true
AllowShortLoopsOnASingleLine: true

mckaygerhard commented 7 years ago

jaja that's geany right?

well in my pull's now i'll use 4 spaces for identation and the clang-format columnwith 100 and AllowShortBlocksOnASingleLine but my "if-else" always be not singleline due consistence coding, i think no problem for us that due are not so dangerous to eyes!

lpereira / hardinfo

Use spaces for indentation throughout #102

Status