GTK3 TODO

[bp0]

GTK3 support was added in #114, but it still has a few issues.

Status

• Hardinfo builds and runs without crashing on GTK3.
• GTK2 continues to work as well as it ever did.
• There are many deprecation warnings during build.
• loadgraph is replaced by Christian Hergert's uber-graph widget for GTK3 hardinfo
• guibench is disabled for gtk3.
• look for TODO:GTK3 in the code to find places that need work.

  grep -nr --include='*.[hc]' "TODO:GTK3" *
  shell/report.c:916:/* TODO:GTK3
  shell/shell.c:366:    /* TODO:GTK3 css-based style */
  shell/shell.c:855:    /* TODO:GTK3 */
  shell/shell.c:888:    /* TODO:GTK3 */
  shell/shell.c:1616:     /* TODO:GTK3 gtk_alignment_new(), etc is deprecated from 3.14 */
  shell/shell.c:1780:    /* TODO:GTK3 */

Testing

mkdir build && cd build
cmake -DHARDINFO_GTK3=1 ..
[etc.]

Things to look at

• modules/computer/display.c: gdkscreen* all deprecated in 3.22.

[lpereira]

As far as the load graph goes, it might be a good idea to use this instead of just porting the current code to Cairo: https://github.com/chergert/uber-graph

It supports multiple graphs, looks nicer, etc.

[bp0]

That may be better, but would it be easier?

[lpereira]

It's not going to be easier, no. For the porting work it might be better to stick with the conversion from GDK drawing primitives to Cairo. Maybe afterwards move it to uber-graph.

[bp0]

Right, I just want to see it build for gtk3. I still have the link problem that I mentioned at https://github.com/lpereira/hardinfo/pull/59#issuecomment-317602114

[bp0]

GTK3 Hardinfo (in XFCE) Broken:

[bp0]

@lpereira I was wrong. Just using uber-graph was significantly easier. Check out #114.

[bp0]

GTK3 and uber-graph: