lpereira / hardinfo

System profiler and benchmark tool for Linux systems
http://hardinfo.org
GNU General Public License v2.0
768 stars 130 forks source link

Reversed polarity for progress bars #16

Closed silv3rm00n closed 7 years ago

silv3rm00n commented 10 years ago

The progress bar indicator is reversed

Here is a screenshot http://s4.postimg.org/o19x16p65/kde_polarity.png

bp0 commented 7 years ago

The looks, to me, like it was fixed.

mckaygerhard commented 7 years ago

gnome-puach fixed only: works in mate, gnome-puach, cinnamon, but in lxde, kde or oopenbox dont

lpereira commented 7 years ago

Indeed, this has been fixed: the whole progress bar code has been rewritten, and even percentages should be consistent now.

Now, I find it curious it's not working on LXDE, KDE, or Openbox. Can you confirm you're running a recent enough version (newer than August 2016)? Is this possibly a theme issue?

mckaygerhard commented 7 years ago

was compiled the same day that i posted the comment, with debian 8.1 and Devuan too

bp0 commented 7 years ago

The polarity is reversed after running a benchmark. I think the benchmark results view must be using the same GTK resources as the filesystem view, and they aren't properly reset when returning to Filesystems. As far as I can tell, it behaves the same without regard to Desktop Environment, but I've only tested in XFCE, LXDE and KDE. I'd bet that GNOME is the same.

mckaygerhard commented 7 years ago

hey! when i paste the snapshot no benchmark was run! i go directly to the filesystem module!

mckaygerhard commented 7 years ago

i have enought desktop environment to test it! dont worry about that, but hey! when i paste the snapshot no benchmark was run! i go directly to the filesystem module!

bp0 commented 7 years ago
mckaygerhard commented 7 years ago

all the tested system are in my house and in my work, at my house a DELL inspiron 15R with Devuan, Xfce4 (i dont like that desktop, i just was installe and i not have time), Jeesie with linux 4.9, GTK 2.24.25 (+/-) and no KDE installed, never run the benchmark here..

at the work, the others, DELL T110-II, HP compat presario C700, those with LXDE 0.5.5 and Debian squeeze (due are very more faster rather recents) and kernel "3.2." using lasted hardinfo (git from yesterday now), with GTK 2.20.2 and Glib 2.25.X , some of these machines have Mate 1.6 and one have Debian 8.1 with recent Mate (i dont remenber version) on those the benchmark was run before test the filesystem..

NOW TAKE CARE OF THAT: i restart the machine with Debian 8, start in clean Openbox desktop, run inmediatelly hardinfo compiled yesterday, goes directly to the filesystem and the firs 20 seconds display info in good , but after 20 seconds some of the filesystems/lines goes to reverse!

NOW UNDER XFCE&MATE: in that dekstop does not happened that!, if i do the same, going directly to the hardinfo filesystem module, but if run benchmarks, benchmarks never ends.. this its in the DELL inspiron 15r with enought power.. so in the DELL with Xfce or Mate, the filesystem bars are correct ...

also an asus Eeepc with Debian etch (quite old but faster) with GTK 2.18.8 and kernel 2.6.34, using hardinfo 0.5.2-pre from May 2017

one machine have a virtualbox with suse, but i dischar due the libc6 problem was solved..

mckaygerhard commented 7 years ago

hey "shoud fix" are not same as "fixed"... at least wait for tests! seems fixed but i not at my work so i cannot test in lxde, openbox, was tested in Xfce and mate and seems in that desktops works now!

bp0 commented 7 years ago

@lpereira I can still make the behavior I described earlier happen. After running any benchmark, except CryptoHash, the filesystems view will be messed up. If selecting CryptoHash and then going back to filesystems, it will be ok again, even if it was messed up before. Select any other benchmark, and it will be messed up again, but CryptoHash will always reset it.

Update: PR #111 fixes this for me.

mckaygerhard commented 7 years ago

i can confirm that described by @bp0 as i posted, now in the morning i go to the work and tested again in openbox, but certanly after running some benchmarks.. the problem still happened