lpereira
commented
3 years ago While this helps for now -- and is part of the solution, although I'd work directly in the database and fix it there rather than modifying the results locally -- I don't think it's the right fix for #556.
I should've been more explicit in the issue, but the idea is that the information should be stored in a machine-parsable format. Columns in the database in the server side of things, and interfacing with the client storing this in a JSON object per result.
So, instead of having something like
"1 physical processor; 4 cores; 8 threads"We'd have this stored in a struct:
struct {
int num_procs;
int num_cores;
int num_threads;
};And store/load that in the JSON that the server operates with.
On Sat, Nov 6, 2021 at 6:28 PM Ondrej Čerman @.***> wrote:
This PR force set English locale when reading the machine information for benchmarks. Then the necessary strings are re-translated when constructing shell string. FIX #556 https://github.com/lpereira/hardinfo/issues/556
The English locale is set by setting the LANGUAGE env. variable and resetting the LC_ALL. Seems to work fine on all my machines, but probably needs more testing whether it works reliably in all environments (BSD?)
You can view, comment on, or merge this pull request online at:
https://github.com/lpereira/hardinfo/pull/630 Commit Summary
- modules/benchmark: save results in english and then retranslate when viewing https://github.com/lpereira/hardinfo/pull/630/commits/7ea2ea7115283884272419813633378954457521
File Changes
(2 files https://github.com/lpereira/hardinfo/pull/630/files)
- M modules/benchmark.c https://github.com/lpereira/hardinfo/pull/630/files#diff-3454ef879ab0d49212d9af68b6ac521e12909ed3df0bcf3afdfd2937d60453df (7)
- M modules/benchmark/bench_results.c https://github.com/lpereira/hardinfo/pull/630/files#diff-1f34e4b51a0f34eb029ac7f2c88f8ea30697326e141544e1f8d717400649fa94 (145)
Patch Links:
- https://github.com/lpereira/hardinfo/pull/630.patch
- https://github.com/lpereira/hardinfo/pull/630.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGLJ7EHDH5UX2T6TZBTUKVXTDANCNFSM5HP3ZQEA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Leandro
ocerman
This PR force set English locale when reading the machine information for benchmarks. Then the necessary strings are re-translated when constructing shell string. FIX #556
The English locale is set by setting the LANGUAGE env. variable and resetting the LC_ALL. Seems to work fine on all my machines, but probably needs more testing whether it works reliably in all environments (BSD?)