search

lpereira / hardinfo

System profiler and benchmark tool for Linux systems
http://hardinfo.org
GNU General Public License v2.0
765 stars 130 forks source link

update of vendor id #648

Open MatrixMike opened 2 years ago

MatrixMike commented 2 years ago

I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress. I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored. I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.

lpereira commented 2 years ago

Thanks for the PR!

"updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.

On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:

I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress. I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored. I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.

You can view, comment on, or merge this pull request online at:

https://github.com/lpereira/hardinfo/pull/648

Commit Summary

(2 files https://github.com/lpereira/hardinfo/pull/648/files)

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

MatrixMike commented 2 years ago

Thanks for your reply. I am slightly confused as to what my actions should be now. I can wait for the robots to pick up the request and process it over the weekend. I enjoy working on this sort of stuff. Best regards and for whatever it is worth ‘happy mothers’ day. No happy mother near me but you might have a good one.

On 4 May 2022, at 23:49, L. A. F. Pereira @.***> wrote:

Thanks for the PR!

"updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.

On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:

I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress. I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored. I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.

You can view, comment on, or merge this pull request online at:

https://github.com/lpereira/hardinfo/pull/648

Commit Summary

(2 files https://github.com/lpereira/hardinfo/pull/648/files)

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

lpereira commented 2 years ago

I've merged this patch, but only the changes to the vendors file (plus the change in the AUTHORS.md). I have not merged the changes to the po files as they haven't been changed by the vendor file change.

On Thu, May 5, 2022, at 9:49 AM, Mike Hewitt wrote:

Thanks for your reply. I am slightly confused as to what my actions should be now. I can wait for the robots to pick up the request and process it over the weekend. I enjoy working on this sort of stuff. Best regards and for whatever it is worth ‘happy mothers’ day. No happy mother near me but you might have a good one.

On 4 May 2022, at 23:49, L. A. F. Pereira @.***> wrote:

Thanks for the PR!

"updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.

On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:

I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress. I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored. I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.

You can view, comment on, or merge this pull request online at:

https://github.com/lpereira/hardinfo/pull/648

Commit Summary

(2 files https://github.com/lpereira/hardinfo/pull/648/files)

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/648#issuecomment-1118369153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGKMU3OBIURIEDP4BBLVIOKSXANCNFSM5VBZBC4Q. You are receiving this because you commented.Message ID: @.***>