search

lpereira / hardinfo

System profiler and benchmark tool for Linux systems
http://hardinfo.org
GNU General Public License v2.0
759 stars 133 forks source link

korean translate update #673

Closed yunlisa96 closed 1 year ago

yunlisa96 commented 1 year ago

I requested a pull request again because there was a part to be corrected in the previous pull request. Please check

lpereira commented 1 year ago

Thanks! I'll merge this as soon as I can. (I'm taking a break from this project so it might take a while.)

On Tue, Sep 27, 2022, at 7:43 PM, yunlisa96 wrote:

I requested a pull request again because there was a part to be corrected in the previous pull request. Please check

You can view, comment on, or merge this pull request online at:

https://github.com/lpereira/hardinfo/pull/673

Commit Summary

(1 file https://github.com/lpereira/hardinfo/pull/673/files)

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGOJ74OKDEBZ37RHZ53WAOWGVANCNFSM6AAAAAAQXKY334. You are receiving this because you are subscribed to this thread.Message ID: @.***>

hamishmb commented 1 year ago

@lpereira, I'm interested in this project - if you'd like another dev to review MRs and make minor changes, I'd be happy to join you. I don't have time to do all of it myself, but I could certainly help if you'd like a hand.

lpereira commented 1 year ago

Merged! Gansahabnida! (I squashed everything in a single commit to make things easier, so it will still show up here as unmerged.)

@hamishmb: That would be helpful, but please understand I can't just give repository push rights without knowing how you'd be as a maintainer. You're welcome to contribute and as soon as you've been around for a while, that's definitely something that can be done.

On Tue, Oct 25, 2022, at 4:46 PM, Hamish Mcintyre-Bhatty wrote:

@lpereira https://github.com/lpereira, I'm interested in this project - if you'd like another dev to review MRs and make minor changes, I'd be happy to join you. I don't have time to do all of it myself, but I could certainly help if you'd like a hand.

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/673#issuecomment-1290854713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGLOKO5QOF5KTM3QJPTWFAFH5ANCNFSM6AAAAAAQXKY334. You are receiving this because you were mentioned.Message ID: @.***>

hamishmb commented 1 year ago

@lpereira Of course, I wasn't assuming that you'd do that - just thinking ahead :)

hamishmb commented 1 year ago

@lpereira, would it be useful if I review and test code in some of the existing merge requests when I get some time?

I'm not sure how, but I guess this one should be marked as merged somehow too.

lpereira commented 1 year ago

Feel free to!

On Tue, Nov 29, 2022, at 9:40 AM, Hamish Mcintyre-Bhatty wrote:

@lpereira https://github.com/lpereira, would it be useful if I review and test code in some of the existing merge requests when I get some time?

— Reply to this email directly, view it on GitHub https://github.com/lpereira/hardinfo/pull/673#issuecomment-1331033642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGMREBQ25AFI65NNUM3WKY5Z7ANCNFSM6AAAAAAQXKY334. You are receiving this because you were mentioned.Message ID: @.***>

hamishmb commented 1 year ago

Okay, shall do :)

lpereira commented 1 year ago

Closing as this has been merged already.