search

lpereira / hardinfo

System profiler and benchmark tool for Linux systems
http://hardinfo.org
GNU General Public License v2.0
759 stars 133 forks source link

Here is the environment cinfiguration: cpu - atom, sd card as bootabl… #704

Closed bayrepo closed 8 months ago

bayrepo commented 8 months ago

…e disk, loist of devices:

/sys/block/zram0 /sys/block/mmcblk0boot0 /sys/block/mmcblk0boot1 /sys/block/mmcblk2 /sys/block/mmcblk0

Hardinfo got nex pathes for reading for the report:

1) # cat /sys/block/mmcblk0/device/oemid 0x0103 2) # cat /sys/block/mmcblk2/device/oemid 0x534d 3) # cat /sys/block/mmcblk0boot0/device/oemid cat: /sys/block/mmcblk0boot0/device/oemid: No such file or directory 4) # cat /sys/block/mmcblk0boot1/device/oemid cat: /sys/block/mmcblk0boot1/device/oemid: No such file or directory

In the code no checks if files from previous step for device was read and pointer not NULL:

gchar oemid_path = g_strdup_printf("/sys/block/%s/device/oemid", e->d->block_dev); gchar manfid_path = g_strdup_printf("/sys/block/%s/device/manfid", e->d->block_dev); gchar oemid = NULL, manfid = NULL; g_file_get_contents(oemid_path, &oemid, NULL, NULL); g_file_get_contents(manfid_path, &manfid, NULL, NULL);

unsigned int id = strtol(oemid, NULL, 16); ... id = strtol(manfid, NULL, 16);

Before srttol need check for NULL

lpereira commented 8 months ago

Merged, thanks!