search

lpereira / lwan

Experimental, scalable, high performance HTTP server
https://lwan.ws
GNU General Public License v2.0
5.94k stars 548 forks source link

This script requires a special version of weighttp which supports JSON output #270

Open nalzok opened 5 years ago

nalzok commented 5 years ago

I can't run make benchmark even after this fork of weighttp is installed.

pi@nalzoks-pi:~/Downloads/lwan/build $ make benchmark
[  3%] Built target bin2hex
[  5%] Built target generate_auto_index_icons
[ 15%] Built target mimegen
[ 16%] Built target generate_mime_types_table
[ 94%] Built target lwan-static
[ 98%] Built target testrunner
[100%] Running benchmark.
Using /home/pi/Downloads/lwan/build/src/bin/testrunner/testrunner for lawn
This script requires a special version of weighttp which supports JSON
output. Get it at http://github.com/lpereira/weighttp
make[3]: *** [CMakeFiles/benchmark.dir/build.make:58: CMakeFiles/benchmark] Error 1
make[2]: *** [CMakeFiles/Makefile2:73: CMakeFiles/benchmark.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:80: CMakeFiles/benchmark.dir/rule] Error 2
make: *** [Makefile:164: benchmark] Error 2

A quick skim of its source code doesn't reveal any JSON related code; in fact, it doesn't even take a -j argument.

https://github.com/lpereira/weighttp/blob/ffd0439e447ef20169d08b5581a4f0770cf43f73/src/weighttp.c#L136-L172

lpereira commented 5 years ago

I apologize for not seeing this issue before. That script is unfortunately out-of-date; it should be adapted to use this rewrite, which has a JSON output and fixes a bunch of issues with the official code. The output is slightly different but it should be possible to modify the script to accommodate for that.