lpereira
commented
2 years ago Patch looks good to me! I'll merge it when I'm near my laptop again. Thanks!
On Mon, May 2, 2022, at 5:21 AM, pontscho wrote:
Hi,
in some cases, for example uses k6 (https://k6.io) for performance testing, the client on the other side sends masked ping message and it uses strict protocol checking, in that case Lwan has to send back payload of ping in a pong message unmasked and has to set the FIN flag on the header. In other cases the other side will drop the connection immediately.
I've fixed this issue based on the original behaviour of Lwan.
pontscho
You can view, comment on, or merge this pull request online at:
https://github.com/lpereira/lwan/pull/344
Commit Summary
- 2e81990 https://github.com/lpereira/lwan/pull/344/commits/2e8199099cca4ab50a3fecfd35a78a977620d624 WebSocket: handling masked ping on proper way File Changes
(1 file https://github.com/lpereira/lwan/pull/344/files)
M src/lib/lwan-websocket.c https://github.com/lpereira/lwan/pull/344/files#diff-ff620aa5c2748fb4b8b5ec2b9b9b349ee1f39f2f8468144aa4287a384e602c80 (49) Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/lpereira/lwan/pull/344, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADVGMCDJGCTAQ5RH3MY7LVH63CTANCNFSM5U3WFODA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi,
in some cases, for example uses k6 (https://k6.io) for performance testing, the client on the other side sends masked ping message and it uses strict protocol checking, in that case Lwan has to send back payload of ping in a pong message unmasked and has to set the FIN flag on the header. In other cases the other side will drop the connection immediately.
I've fixed this issue based on the original behaviour of Lwan.
pontscho