lpereira / lwan

Experimental, scalable, high performance HTTP server
https://lwan.ws
GNU General Public License v2.0
5.94k stars 548 forks source link

Completion of error handling #59

Closed elfring closed 9 years ago

elfring commented 10 years ago

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

lpereira commented 9 years ago

All reported spots have been fixed. Thank you.

elfring commented 9 years ago

How do you think about to reconsider also return values from a call of a function like "close"?

lpereira commented 9 years ago

There's nothing to do under Linux, except reporting it. Even handling EINTR is incorrect under Linux (might introduce a race condition).

elfring commented 9 years ago

Would you like to detect every error situation as early as possible?

How do you think about to care also for return values from a function like "pthreadmutex(un)lock"?