search

lphillips / SecretHitlerDiscord

A discord bot for the famous board game Secret Hitler
Other
1 stars 0 forks source link

Make emoji names more unique #18

Closed bsmccain closed 3 years ago

bsmccain commented 3 years ago

fixes #14

lphillips commented 3 years ago

I'm not a fan of the substring search to find the emoji. Maybe the declaration of these JA and NEIN constants should be in the config instead of the app itself?

bsmccain commented 3 years ago

This is a situation of design principles vs practicality. I agree with you in principle, but the problem being solved here is frankly not worth the time we've put into making changes and thinking about it thus far. It's the scripter's fallacy...spend an hour writing code to avoid copying and pasting two strings. The truth is these are extremely unlikely to change again, so this work is not really going to save anything later.
With that said, regardless of what we pick for names, collisions are possible, so I've been pondering solutions to that in code, which would more or less make this issue moot. So let's just merge this one to get the names in, and I'll open an issue to enhance emoji handling in the app (and probably all image handling, since they're all hardcoded paths all over the code right now anyway).

lphillips commented 3 years ago

That all makes sense. It's always a fine line between "this is a simple improvement that enhances reliability and correctness" and "this change has a minor positive impact that won't ever matter, practically speaking". I'll go ahead and merge this.