search

lpiccinelli-eth / UniDepth

Universal Monocular Metric Depth Estimation
Other
462 stars 39 forks source link

Output for v1 versus v2 uses different names for intrinsics #43

Open pablovela5620 opened 1 month ago

pablovela5620 commented 1 month ago

Would be good to have consistent names between both models

V1

https://github.com/lpiccinelli-eth/UniDepth/blob/3a5715af4af88d3c907cc2f40498d01a26e265ec/unidepth/models/unidepthv1/unidepthv1.py#L254

V2

https://github.com/lpiccinelli-eth/UniDepth/blob/3a5715af4af88d3c907cc2f40498d01a26e265ec/unidepth/models/unidepthv2/unidepthv2.py#L275

lpiccinelli-eth commented 1 month ago

Thanks to bring this up, we will amend it