add label to modifiers field

lpil / elixre

🦑 An Elixir regular expression editor & tester, with Elm

http://elixre.lpil.uk/

GNU Affero General Public License v3.0

101 stars 10 forks source link

add label to modifiers field #17

Closed lau closed 9 years ago

lau commented 9 years ago

Nice website! I just saw it. The only thing I wondered was: what is the little unlabeled second field for? This adds a label to it.

lpil commented 9 years ago

Hi Lau! This looks good! :)

A few things about the implementation:

We're not using IDs, could you use comments instead?
We're not using camelcase. Could you use BEM notation with dashes for word separators please? See the surrounding classes.
Could you remove the redundant label and div in the selectors please?
Do we need the regexAndModifierInput ID at all? We could use the existing .inputs rather than add a new identifier.

Cheers, Louis

lau commented 9 years ago

I don't have so much time for that. You are welcome to change those things if you think that's better. Or implement it in any way you like. I just wanted a label there.

lpil commented 9 years ago

OK, I'll rebase this in and tweak it a bit. Thanks!