Create POST /regex route which accepts JSON body and sends JSON response

lpil / elixre

🦑 An Elixir regular expression editor & tester, with Elm

http://elixre.lpil.uk/

GNU Affero General Public License v3.0

101 stars 10 forks source link

Create POST /regex route which accepts JSON body and sends JSON response #40

Closed scripttease closed 8 years ago

scripttease commented 8 years ago

:snail:

lpil commented 8 years ago

Looks great! A few comments :)

scripttease commented 8 years ago

A few questions:

When I make only minor modifications, as in this case, should I just amend the previous commit? Or make a new commit? If the latter, what would a suitable commit message be?
Why is the Travis CI failing? (The tests passed.)

lpil commented 8 years ago

Another commit is fine. :)

Looks like Travis errored. I'll look closer now

lpil commented 8 years ago

Problem with npm. npm is a bit rubbish.

I'm re running it now.

lpil commented 8 years ago

It passed! :)

scripttease commented 8 years ago

WAHOOOOOOO :D <3

On 7 April 2016 at 08:02, Louis Pilfold notifications@github.com wrote:

Merged #40 https://github.com/lpil/elixre/pull/40.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/lpil/elixre/pull/40#event-617916984