deserialize handles multiple events in ics

lpil / icalendar

🗓️ A small library for reading and writing ICalendar files.

MIT License

103 stars 56 forks source link

deserialize handles multiple events in ics #36

Closed ericdude4 closed 5 years ago

ericdude4 commented 5 years ago

Current implementation deserializes only the last event in the calendar and returns the single event. This has to be a bug since an .ics file can contain any number of events.

I included some passing tests.

Some other improvements:

support for empty keys
```
BEGIN:VEVENT
DESCRIPTION:
END:VEVENT
```

support for date strings since this is common in Google calendar .ics links

BEGIN:VEVENT
DTSTART;VALUE=DATE:20190624
DTEND;VALUE=DATE:20190625
END:VEVENT

lpil commented 5 years ago

Hi, sorry could you rebase to fix the merge conflicts?

ericdude4 commented 5 years ago

@lpil done! Thanks for getting back to me.

dhanson358 commented 5 years ago

Hate to pester, but any ETA on this being merged? I have some need for this exact functionality!

ericdude4 commented 5 years ago

@dhanson358 I am just waiting for him to merge it in. You can always use my forked repository for the time being.

lpil commented 5 years ago

Thank you!