search

lpil / icalendar

🗓️ A small library for reading and writing ICalendar files.
MIT License
103 stars 56 forks source link

Deserialization of ics into Event Structs #6

Closed johnhamelink closed 8 years ago

johnhamelink commented 8 years ago

This PR is designed to allow for this module to be able to parse ics strings into Event Structs to be read or manipulated in a standard format. This is useful if you are importing ics strings into a database, or if you want to edit an ics.

lpil commented 8 years ago

Seems like a good feature.

johnhamelink commented 8 years ago

I've moved the deserialization process into a utils module. I wasn't happy with the rather verbose way I'd implemented it first, so I used named regex parameters to make it a bit cleaner.

I also added some doctests and moved some of the parsing-specific tests into the test suite for the deserialization module.

lpil commented 8 years ago

Nice. I've added one little comment :)

johnhamelink commented 8 years ago

@lpil should be sorted now :+1:

lpil commented 8 years ago

Ace, thanks!

lpil commented 8 years ago

@johnhamelink Ah! This broke documentation generation :(

Do you think you could take a look at this please? Run the mix docs task to see what I mean. Also if you could add mix docs as a test to the travis.yml file so this can be caught that would be ace. Thanks

johnhamelink commented 8 years ago

Will do, no problem :)

lpil commented 8 years ago

Thank you.