search

lpotthast / axum-keycloak-auth

Protect axum routes with a JWT emitted by Keycloak.
https://crates.io/crates/axum-keycloak-auth
Apache License 2.0
34 stars 13 forks source link

Cargo.toml: allow users to specify tls implementation #13

Closed dspicher closed 5 months ago

dspicher commented 7 months ago

We allow the user to choose between the default native-tls and rustls TLS implementations for the reqwest dependency. The default behaviour remains activating the previously used, default native-tls implementation, thus not breaking any clients.

Closes #11.

dspicher commented 6 months ago

Hey @lpotthast would it be possible to get a review on these two open PRs?

Tockra commented 6 months ago

@lpotthast I'm interest too

lpotthast commented 5 months ago

Tanks for the PR! Looking at the current feature declarations in https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml, a few questions came to mind: 1) The newest reqwest update introduced more default features. We should probably add them back manually. What are your thoughts? (see: https://github.com/seanmonstar/reqwest/compare/v0.11.27...v0.12.0#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542) 2) There does not seem to be a "rustls" feature (anymore), activating "rustls-tls" should be sufficient. 3) If we provide "default-tls", we should probably name the second feature "rustls-tls", to match the schema and to closely match reqwests feature names.

dspicher commented 5 months ago

Thanks for the review! I opened https://github.com/lpotthast/axum-keycloak-auth/pull/19 as a preceding PR to update reqwest.

dspicher commented 5 months ago
  1. ...

Done.

  1. ...

Done.

  1. ...

Done.

lpotthast commented 5 months ago

Looks good! Thanks for the quick changes.