lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
327 stars 19 forks source link

Co-authored-by: functionality overwritten #111

Closed TheGreatRefrigerator closed 1 year ago

TheGreatRefrigerator commented 1 year ago

Co-authored-by, Signed-off-by and similar footers are auto-completed by jetbrains IDEs already. When i use the conventional commit plugin, i can't choose between the authors anymore, but get the same suggestions as for the commit message subject:

Screenshot 2023-03-13 at 16 35 32

I would love it, if that feature would still be available when using this plugin.

lppedd commented 1 year ago

@TheGreatRefrigerator hey there, is that 2023.1? Asking because I can't reproduce on 2022.3.

lppedd commented 1 year ago

A part of the enhancement is done in https://github.com/lppedd/idea-conventional-commit/commit/4220326ff4aad86934fc7dc05307e7f94654a6a6.

Another commit will follow soon to improve the logic for these specific footer types.

TheGreatRefrigerator commented 1 year ago

@TheGreatRefrigerator hey there, is that 2023.1? Asking because I can't reproduce on 2022.3.

Hey i just reproduced this on WebStorm 2022.3.4. Thx for the quick reaction ⚡

lppedd commented 1 year ago

@TheGreatRefrigerator so basically what you don't want is seeing suggestions not related to users/emails?

TheGreatRefrigerator commented 1 year ago

I just want the suggestions to fit the current input place. At the start it suggests a type, then in brackets the scope, then afterwards suggestions from previous commit msg headers. But after Co-authored-by: i don't want to have a suggestions for the commit msg headers again. I need to input an author there...

lppedd commented 1 year ago

@TheGreatRefrigerator with the new update you should not see proposals other than authors. Is it not working properly?

TheGreatRefrigerator commented 1 year ago

Perfect! After the update it works again properly. Thx a lot! Have a ⭐