search

lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
327 stars 19 forks source link

Incompatible with version 2024.1 EAP #132

Closed dschewchenko closed 2 months ago

dschewchenko commented 4 months ago

Please update =(

bric3 commented 4 months ago

@dschewchenko PR welcome ;)

I believe a new version of the plugin will be released when 2024.1 is released, maybe a tad before. IJ platform API breaking change is still possible until IJ platform stabilise their changes.

And one can build the plugin from source.

lppedd commented 4 months ago

Exactly. Personally I didn't get to use 2024.1 because of a bunch of issues with Angular, so it wasn't a pressing change. I'm still stuck with 2023.3.2.

It will get released as soon as the final version is out.

lppedd commented 4 months ago

The source code is already compatible with 2024.1 btw, I just didn't test it enough.

bric3 commented 4 months ago

@lppedd By the way actions are now raising this, I believe this need to be fixed for 242. But the error report is there.

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.github.lppedd.cc.vcs.ClearLocalMessageHistoryAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.github.lppedd.idea-conventional-commit]
    at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
    at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
    at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
    at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
    at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)

This API was introduced in 222 I think. And it was added to control whether an action should be updated on the EDT, or if it can be performed on background. The idea is to avoid using EDT to avoid UI freeze.

One way to fix it is to write the method and lookup the enum values by reflection. Or to bump the minimum version to 222 and override these methods.

lppedd commented 4 months ago

Thanks @bric3! I'll just bump the minimum version to when the enum appeared, and we should be good again!

lamb218 commented 3 months ago

Please update, thank you!

prshnt commented 2 months ago

Hi @lppedd now that the 2024.1 is out, would you mind updating the plugin. Thank you for the plugin.

lppedd commented 2 months ago

Definitely. Well be pushed to the marketplace during the weekend.

Eraldo commented 2 months ago
Screenshot 2024-04-05 at 22 49 05

Running PyCharm 2024.1

lppedd commented 2 months ago

I've just uploaded version 0.23.0 to the Marketplace, and I suppose it will be available by tomorrow EOD.
If you can't wait for the Marketplace approval, you can grab the .zip file for manual installation here.

I'll keep the issue open until it's approved.

Nicoss54 commented 2 months ago

I've just uploaded version 0.23.0 to the Marketplace, and I suppose it will be available by tomorrow EOD. If you can't wait for the Marketplace approval, you can grab the .zip file for manual installation here.

I'll keep the issue open until it's approved.

thanks for your work! You rock it.

mlec1 commented 2 months ago

The plugin is now available on the marketplace