lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
336 stars 18 forks source link

Make CoAuthors file path configurable #36

Closed TjarkoG closed 3 years ago

TjarkoG commented 3 years ago

Hi there First of all. Great work with this plugin. I work in a Team with allot of projects. Since we try to work with Pair-Programming as much as possible almost every commit has a coauthor assigned to it. Thats why i would love to be able to configure the destination of the file that contains the known CoAuthors. If i could define the Path of the CoAuthors file i would only need to populate it once and i could reuse it for every project. Thanks

lppedd commented 3 years ago

Hi! I think it's a fair request. But remember the settings are per-project, so you'd have to pick the file for each new project. Is this an acceptable behavior?

TjarkoG commented 3 years ago

Hi Thanks for the quick response. To me this would be okay. That was the expected behaviour anyway.

lppedd commented 3 years ago

@TjarkoG ok! I'll give a look later and see how I can do this. The code should already be flexible enough.

lppedd commented 3 years ago

I have started adapting the settings UI to allow scrolling, and thus make the insertion of a new configuration option more comfortable.

lppedd commented 3 years ago

The UI side is finished. I will post examples for feedback.

lppedd commented 3 years ago

@TjarkoG Feedback is appreciated! @ymind are you still on for some translations? I have modernized the panels and thus some properties. 😄

Upgraded settings panel.

image

Contextual help.

image

File picker. The file picker will highlight the applicable files only. The others will be displayed with a generic icon.

image

ymind commented 3 years ago

Received, I will finish as soon as possible!

TjarkoG commented 3 years ago

Looks really nice. Thanks for the really fast implementation. I'm not used to having my wishes resolved that fast. Great work.

TjarkoG commented 3 years ago

If you tell me how i could proppably translate to german if you want.

lppedd commented 3 years ago

@ymind no hurry 😄 I'll make a list of what's changed so it's easier for you.

@TjarkoG that's cool, I will add an explanation to the README, thanks!

ymind commented 3 years ago

@lppedd Well, I've finished the missing translations. Waiting for your new code.

lppedd commented 3 years ago

A quick update. Before pushing the code for this issue I wanted to do a general clean-up, that's why it's still open.

I will push everything tomorrow, but the release is blocked by another improvement I'm coding unfortunately (I'm dumb and I've tied things together). The improvement is a refinement of the plugins API.

However I plan to finish for the end of the week.

TjarkoG commented 3 years ago

No worries. Its not that urgent. Take your time. If it was in two weeks it would still be way faster than expected ^^

lppedd commented 3 years ago

As promised, pushed with commit 4888b3ae97eba204e41e6ad5090915075ee252a3 I'll close when @ymind finish the translations 🚀

iilei commented 3 years ago

Great stuff, I was about to suggest a similar feature (auto-discovery via directory traversal by default)

lppedd commented 3 years ago

@iilei well, the auto discovery exists actually 😅 it doesn't work in 2020.3 because they changed an API result value and I didn't properly test it unfortunately. The auto discovery works under the .idea folder for 2020.3. The fix is planned for next release, soon 😎

lppedd commented 3 years ago

@TjarkoG @iilei I have a good news. Today I managed to finish and test my new implementation of the completion process. That allows me to release this co-authors enhancement on monday!

lppedd commented 3 years ago

Hey! Yesterday I uploaded the plugin on the Marketplace. You just need to wait for it to be accepted 😄