lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
327 stars 19 forks source link

chore: Update translations #36 #37

Closed ymind closed 3 years ago

ymind commented 3 years ago

Close #36

lppedd commented 3 years ago

Hey! Thanks a lot :smile:

lppedd commented 3 years ago

I think there are a couple of messages to align, which maybe you didn't notice.

cc.config.info=Perform commit completion using:
cc.config.types=Types:
cc.config.scopes=Scopes:
cc.config.coAuthorsDialog.error=Co-author's names cannot be blank

And btw, feel free to omit colons or whatever if it's not appropriate for Chinese (I need to learn it 😆).

ymind commented 3 years ago

Thank you for noting this, I've re-checked all entries and corrected them.

I deliberately omitted the colon for the following two entries:

cc.config.types=Types:
cc.config.scopes=Scopes:

Most times the colon in the title is not necessary in Chinese.

I also fixed the translation of the following entries:

cc.config.providersPriority=Personalize the providers priority (higher in the list equals higher priority).
cc.config.providersPriority=自定义提供程序优先级 (越靠前优先级越高)。

This may be caused by an incorrect copy and paste.


If you like or studying Chinese, I admire it! As far as I know, Chinese is very difficult for most foreigners. I am not a professional language teacher, but if I can help you, I will be very pleased!

lppedd commented 3 years ago

Awesome, thanks for the update! I'll merge tonight after pushing the latest code.

I have a question regarding properties like

cc.whatsnew.dialog.newer=&Newer

In the standard file I've used the & character to let a user use keyboard shortcuts (ALT+N in this case). How does it work with Chinese?


Edit: I have also added a colon to

cc.config.providers.type.title=Type providers:
cc.config.providers.scope.title=Scope providers:
cc.config.providers.subject.title=Subject providers:

and introduced

cc.config.providers.body.title=Body providers:
cc.config.providers.footerType.title=Footer type providers:
cc.config.providers.footerValue.title=Footer value providers:
ymind commented 3 years ago

About keyboard shortcuts, the general approach is:

cc.whatsnew.dialog.newer=&Newer
cc.whatsnew.dialog.newer=新版本(&N)

This will be shown as: image

BUT, I didn't find a way to visit the GUI during the test, so I omitted it temporarily. I'm not sure if 新版本(&N) will disturb with the UI display.


The translation has been updated.

lppedd commented 3 years ago

Thanks! No problem for the shortcuts, you can add them later on if you want.

To test that UI part you should use the What's new in Conventional Commit action, under help, though it's empty so buttons will be grayed out. Example:

image

lppedd commented 3 years ago

Last added message before release, I promise 😄

cc.config.filePicker.error.existence=The file does not exist
ymind commented 3 years ago

image

I find it!

Comprehensive screenshot and source code, I understand the newer and older here as next and previous. There are two way translations:

A

# direct translation
cc.whatsnew.dialog.newer=较新 (newer)
cc.whatsnew.dialog.older=较旧 (older)

B

# integrated with Chinese customary translation
cc.whatsnew.dialog.newer=下一版 (next)
cc.whatsnew.dialog.older=上一版 (previous)

I'm using B now, please confirm !

And the Close button text has no translate entity. Is this due to IDEA API restrictions?

lppedd commented 3 years ago

Yes, newer and older are used as alias for next and previous (there are new releases and old releases so it seemed appropriate).

I'd say: go with B if you've already seen it used in other programs, otherwise go with A. The B choice looks this way with version numbers:

image

I could probably make the Close button translatable, let me check. That button comes from the IDEA Platform

lppedd commented 3 years ago

Ok, the new property is

cc.whatsnew.dialog.close=&Close
lppedd commented 3 years ago

And I have a question. Many localized strings ends with the ideaographic full stop charachter.
Does it represent a simple dot (like in english) or does it have a special role in the sentence? If it's a simple dot I would remove it from some places, per UI guidelines, let me know 😄

image

ymind commented 3 years ago

image

This is a full stop in Chinese. Usage is equivalent to english '.'.

In this commit, I removed them.


In this translation work, you let me learn a lot of things, thank you very much!

lppedd commented 3 years ago

@ymind thanks a lot to you! Merged successfully.