lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
327 stars 19 forks source link

feat: add new type `chore` #4

Closed bluelovers closed 4 years ago

bluelovers commented 4 years ago

https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716

karfau commented 4 years ago

At some point I thought that build and ci was "the newer way" to write "chore" but I'm not able to find that reference anymore. It seems that many related tools offer both all three ways, but the description for chore varies a lot.

Iwould love it, if the description is written in a way that those three don't have an overlap, otherwise it's hard to consistently pick the "right one".

I think currently the description is not " overlap-free".

Maybe it would rather make sense to offer two "default configs, one with chore, the other one with buil d and ci? Not sure.

Just my 2 cents.

bluelovers commented 4 years ago

https://www.spinnaker.io/community/contributing/submitting/

lppedd commented 4 years ago

Sorry guys, I've been sick, will begin working in this again shortly

lppedd commented 4 years ago

Will re-evaluate after #3 is fixed.

tad3j commented 4 years ago

I'm using conventional-changelog and I notice that revert is also missing, maybe it could get added?

lppedd commented 4 years ago

@tad3j revert should have been there since the beginning, I totally forgot about it!

bluelovers commented 4 years ago

still didn't wanna take chore?

lppedd commented 4 years ago

@bluelovers oh, I forgot about it actually. Are you using a custom config file now or you just type it by hand?

bluelovers commented 4 years ago

just type it by hand

lppedd commented 4 years ago

@bluelovers Ouch. Why didn't you create a custom file? I'm asking just to understand

bluelovers commented 4 years ago

because i think it should be include in default

lppedd commented 4 years ago

@bluelovers but doesn't it collide with build and docs ?

bluelovers commented 4 years ago

but many project use it

lppedd commented 4 years ago

@bluelovers I will add it, but without scopes, as they're not well defined. Reasonable?

bluelovers commented 4 years ago

yes, i think is ok

https://github.com/ipfs/js-ipfs/commits/master

lppedd commented 4 years ago

Close with 720f1f5103d6ec825c216bdaeb356c053586b64e