lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
336 stars 18 forks source link

Provide commit message insertion via dialog template #49

Closed lppedd closed 3 years ago

lppedd commented 3 years ago

See TextFieldWithCompletion.
Seems impossible to reuse the CompletionContributor, so we need to wire up everything again.

Idea from #35

lppedd commented 3 years ago

Example:

image

cc @patrek

lppedd commented 3 years ago

Current state:

image

patrek commented 3 years ago

Nice.

Don't know how difficult it is, but I would make type selectable form usual values somehow.

I would also add a field where one can enter the issue number

lppedd commented 3 years ago

@patrek as you can see from the first screenshot, you can still complete each field with completion values (usual popup). Is that what you mean?

I would also add a field where one can enter the issue number

Yeah! I'll add the possibility of inputting a single footer.

patrek commented 3 years ago

yes, that is perfect. I did not understand the first screen shot properly.

for the single footer, as long as the completion makes it easy to make one for the issue number, that would be perfect.

The idea is to put that in the hands of a junior developper to bring him up to speed rapidely

lppedd commented 3 years ago

Seems ok! Then, what is still missing:

lppedd commented 3 years ago

@patrek I will push the commits on thursday and the marketplace update on friday 😄 I used this dialog to learn about accessibility for disabled people. Sorry for the late update.

patrek commented 3 years ago

wow! thanks!

Don't be sorry, your turn around was fast!

lppedd commented 3 years ago

Status update: I wasn't able to commit because of issues I found. The design is finished, need to fix a logic flaw.
The dialog can be opened using an action button, as per following screenshot:

image

And here is the dialog itself:

image

In 0.20.0 I'll add the possibility of inputting multiple footers.

lppedd commented 3 years ago

Implemented with commit c8928cacf1e57770f8f1f208502577b643f594ef Closing for now 😄