search

lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
336 stars 18 forks source link

feat: Support for intellij idea until 221.* version #74

Closed Miuler closed 2 years ago

Miuler commented 2 years ago

feat: Support for intellij idea until 221.* version

bric3 commented 2 years ago

I noticed this error when running the plugin against 221 EAP

java.lang.AbstractMethodError: Receiver class com.github.lppedd.cc.CCApplicationLoadListener does not define or inherit an implementation of the resolved method 'abstract void beforeApplicationLoaded(com.intellij.openapi.application.Application, java.nio.file.Path)' of interface com.intellij.ide.ApplicationLoadListener.
    at com.intellij.idea.ApplicationLoader.initConfigurationStore(ApplicationLoader.kt:422)
    at com.intellij.idea.ApplicationLoader$initApplication$block$3.apply(ApplicationLoader.kt:137)
    at com.intellij.idea.ApplicationLoader$initApplication$block$3.apply(ApplicationLoader.kt)
    at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1187)
...

It is because the path has been changed to a Path, while the previous (unstable) API this argument was a String.

https://github.com/lppedd/idea-conventional-commit/blob/97bf78ac1757379f035c58cd8706381d9bcb8da1/src/main/kotlin/com/github/lppedd/cc/CCApplicationLoadListener.kt#L13

The're maybe other surprises. In my opinion it would be better to change the target to 221.

Coobaha commented 2 years ago

ping @lppedd 221 was promoted to Beta from EAP recently

bric3 commented 2 years ago

@Coobaha @Miuler You might want to check out #77