search

lppedd / idea-conventional-commit

Context and template-based completion for conventional/semantic commits.
https://plugins.jetbrains.com/plugin/13389-conventional-commit
MIT License
327 stars 19 forks source link

Can't have Conventional Commit and Return Highlighter installed at the same time #99

Closed sweethuman closed 1 year ago

sweethuman commented 1 year ago

If I have Conventional Commit installed, and I install Return Highlighter; after I restart WebStorm Conventional Commit will be uninstalled. If I have Return Highlighter installed, and I install Conventional Commit; after I restart WebStorm Return Highlighter will be uninstalled.

I get no errors, no nothing, installing either one goes well. I have no clue why this is happening, but it keeps happening.

lppedd commented 1 year ago

I have noticed this too. Asked on the Plugins Slack channel but got no answers. Will investigate

sweethuman commented 1 year ago

Backtick doesn't seem to force either plugin to uninstall. It's only between those two.

lppedd commented 1 year ago

@sweethuman so I've been "away" for a bit. Turns out Return Highlighter had a name reference to Conventional Commit that caused the silent overwrite. This has been reported to JB as imo it is very dangerous. My mistake in this case, but a bad actor could cause all sort of damage.

See https://github.com/lppedd/idea-return-highlighter/commit/0751b4cdd07bf1545c4728ad06a4abadc5cc434f

lppedd commented 1 year ago

Return Highlighter 0.8.3 will be available next week from the marketplace, or you can grab it from its repository Release section.

sweethuman commented 1 year ago

Very interesting issue. Thank you so much!!!!