lpradel / steam-web-api-java

:steam_locomotive: Java library to provide access to the data available from Valve's Steam API
Apache License 2.0
78 stars 16 forks source link

Upgrade to httpclient5 #12

Closed 41zu closed 2 years ago

41zu commented 2 years ago

Hi,

I saw that this library doesn't work on Andoird, because Google uses an defacto fork of httpclient 4. That issue should be resolved with httpclient version 5.

But there are still 4 tests failing and I'm sadly no expert when it comes to mocking. So I'm not able to resolve those failing tests, an easy option would be to just remove them, but I'm not an fan of that :/

I also lowered the source and target Java version to 8, so it will work without problems on Android. No code changes where needed for that. The only change for this is, deactivating the adding of the @Generated annotation in the jsonschema2pojo plugin, because this annotation is causing issues, when changing between Java versions.

I also changed the SteamApiException to an RuntimeException, which has the result that the compiler doesn't force you to handle this exception. This makes it possible/nicer to use it in lambdas. Otherwise it shouldn't change any behavior.