search

lpradel / steam-web-api-java

:steam_locomotive: Java library to provide access to the data available from Valve's Steam API
Apache License 2.0
77 stars 16 forks source link

Dependency updates #18

Closed 41zu closed 1 year ago

41zu commented 1 year ago

Hi,

I updated all dependencies again, plus TestNG and Mockito to their respective latest versions (TestNG has a new CVE).

But the new TestNG version needs Java 11, so we have to finally bump it up.

Plus I removed a few unused warnings.

I would appreciate it if you could release a new version. I would argue for 1.5 because we had to upgrade to a new major Java version.

Best regards 41zu

lpradel commented 1 year ago

Good job, I was hoping I would find some time to do it myself 👀 but yeah I saw already that to fix the CVE we would have to bump TestNG and thereby go Java 11 after all. Will review this soon

41zu commented 1 year ago

@lpradel I just noticed, Java 11 is only required to run the tests. We can still compile the classes to Java 8. Changed the pom to Java 8 again. So it would be enough to just release version 1.4.2 because, we only update dependencies.

41zu commented 1 year ago

@lpradel thank you for merging and releasing the new version 👍🏻