Replace the HTTP Client from Apache httpclient5 to java.net.http

lpradel / steam-web-api-java

:steam_locomotive: Java library to provide access to the data available from Valve's Steam API

Apache License 2.0

78 stars 16 forks source link

Replace the HTTP Client from Apache httpclient5 to java.net.http #23

Closed 41zu closed 1 year ago

41zu commented 1 year ago

upgraded dependencies and plugins
added SteamApiKeyException for when the API Key is null

lpradel commented 1 year ago

Hi thanks a lot for your latest contribution! I will try to review ASAP. Sorry for the inconvenience but could you re-integrate with master? I merged Joey's changes as he was first as 1.6.0 so you should make this into 1.6.1.

Thanks!

lpradel commented 1 year ago

Actually on second thought I think this warrants 1.7.0 !

41zu commented 1 year ago

I rebased my fork with master,

and I also think 1.7.0 is required.

41zu commented 1 year ago

@lpradel do you have any suggestions for improvement or objections for the code in this MR?

lpradel commented 1 year ago

Sorry for the delay, was away on leave in the pyrenees 🏍️

41zu commented 1 year ago

Thank you for your feedback, I will try to address your suggestions

lpradel commented 1 year ago

I went ahead and made the suggested changes myself, hope it's ok with you

lpradel commented 1 year ago

Thanks again for your contribution!

41zu commented 1 year ago

Thank you for taking the time and making the effort to implement the changes. Unfortunately, I haven't had much time lately.