search

lprhodes / broadlinkjs-rm

Control the IR and RF interfaces within Broadlink RM devices.
MIT License
57 stars 52 forks source link

Added addDevice function and cleaned up code #1

Closed Qata closed 6 years ago

Qata commented 7 years ago

This is the first of two pull requests, the other will be on homebridge-broadlink-rm to add support for manually specifying device locations. (My home network doesn't support UDP broadcast and this is a nice option to have).

tianshuo commented 6 years ago

Hi, please add 0x279d to the array of pro_plus_device_types, the device is RM3 Pro Plus. Which will solve this bug: https://github.com/lprhodes/homebridge-broadlink-rm/issues/208

Qata commented 6 years ago

@tianshuo Added

lprhodes commented 6 years ago

Thanks for this, I've not ended up using it as I've cleaned up the code further. Within the cleanup support for what you wanted fell into place naturally.

The method is this.addDevice(host, macAddress, deviceType);

I'm adding support to the homebridge-broadlink-rm plugin now.