search

lprhodes / homebridge-apple-tv

Apple TV 4th & 5th gen plugin for homebridge: https://github.com/nfarina/homebridge
Apache License 2.0
105 stars 15 forks source link

Less verbose logging? #8

Closed epheterson closed 6 years ago

epheterson commented 6 years ago

It looks like we're logging 4 lines for each button press. That's maybe a little excessive, as only one is necessary and the rest is a bit redundant.

We currently print:

[2018-4-2 21:23:26] [Apple TV] Down setSwitchState: true
[2018-4-2 21:23:26] [Apple TV] Down sendCommand (down)
[2018-4-2 21:23:26] [Apple TV] Down setSwitchState: (automatically turn off in 0.1 seconds)
[2018-4-2 21:23:26] [Apple TV] Down setSwitchState: false

Instead it should only print: [2018-4-2 21:23:26] [Apple TV] Down sendCommand (down)

The setting in config.js defines the enableAutoOff behavior, so printing on/action/timer/off is unnecessary.

lprhodes commented 6 years ago

You may use disableLogs if you wish, I'm not looking to go any further sorry