search

lpsinger / ligo.skymap

Localization of gravitational-wave transients. Mirror of https://git.ligo.org/lscsoft/ligo.skymap
23 stars 18 forks source link

Inconsistent tuple lengths in find_ellipse #17

Closed bpiotrzkowski closed 2 years ago

bpiotrzkowski commented 2 years ago

When testing in gwcelery, an error was found in find_ellipse where the expected values to unpack were different from expected Screen Shot 2022-10-06 at 10 35 13 AM

This appears to occur due to the tuples returned being different lengths, with the standard output being six values https://github.com/lpsinger/ligo.skymap/blob/ba63039d857d5097417e5d967d7d6db185327d5f/ligo/skymap/postprocess/ellipse.py#L387 and the error output being five https://github.com/lpsinger/ligo.skymap/blob/ba63039d857d5097417e5d967d7d6db185327d5f/ligo/skymap/postprocess/ellipse.py#L371 This could be fixed by changing the latter output to six np.nan values.

lpsinger commented 2 years ago

Would you please report this at https://git.ligo.org/lscsoft/ligo.skymap/-/issues/new?

bpiotrzkowski commented 2 years ago

Done: https://git.ligo.org/lscsoft/ligo.skymap/-/issues/35